Skip to content

Remove cassandra-all #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 14, 2022
Merged

Remove cassandra-all #6

merged 5 commits into from
Mar 14, 2022

Conversation

mjok
Copy link
Contributor

@mjok mjok commented Mar 4, 2022

this prone to collect vulnerable libs and sparsely used.
I think code copy would benefit more.

@maximevw
Copy link
Collaborator

maximevw commented Mar 5, 2022

Hello @mjok,
Thanks a lot for your pull request. I will review it as soon as possible.
Could you please modify it to merge into release/next branch as requested in our contributing policy? We´ll take advantage of your changes to build and release a new minor version (4.6.0) including other changes already included into this branch.

@mjok mjok changed the base branch from master to release/next March 7, 2022 07:28
@maximevw
Copy link
Collaborator

Hello @mjok
Did you see the other comments on the pull request or didn't have you just the time to review them?

@mjok
Copy link
Contributor Author

mjok commented Mar 10, 2022 •
edited
Loading

Didn't saw any comment other than branch to merge. Can't see any of them now.
I did change the branch.

maximevw
maximevw requested changes Mar 10, 2022
View reviewed changes
pom.xml Outdated
<commons-lang3.version>3.11</commons-lang3.version>
<datastax.java.driver.version>4.10.0</datastax.java.driver.version>
<datastax.java.driver.version>4.13.0</datastax.java.driver.version>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A version 4.14.0 is even available for 2 weeks.

@maximevw
Copy link
Collaborator

Didn't saw any comment other than branch to merge. Can't see any of them now. I did change the branch.

Sorry @mjok, my bad... I forgot to submit my review 😄

@maximevw maximevw self-requested a review March 10, 2022 09:41
@maximevw
Copy link
Collaborator

Hello @mjok, still one comment to review: please update Datastax driver to 4.14.0. Then, I'll be able to validate your pull request and prepare a new version.

@mjok
Update pom.xml
1178faf 
update to 4.14
maximevw
maximevw approved these changes Mar 14, 2022
View reviewed changes
Copy link
Collaborator

@maximevw maximevw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll prepare the release 4.6.0 very soon including these changes.
Thank you @mjok for your contribution.

@maximevw maximevw merged commit da12a8a into ing-bank:release/next Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximevw maximevw maximevw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjok @maximevw